Add config options to disable checks
This commit is contained in:
parent
90215c0ce3
commit
9767667760
8
.github/workflows/build.yaml
vendored
8
.github/workflows/build.yaml
vendored
@ -60,3 +60,11 @@ jobs:
|
|||||||
echo "Previous step result: ${{ steps.invalid_schema_test.outcome }}"
|
echo "Previous step result: ${{ steps.invalid_schema_test.outcome }}"
|
||||||
echo "Expected the invalid schema test to fail, but it succeeded"
|
echo "Expected the invalid schema test to fail, but it succeeded"
|
||||||
exit 1
|
exit 1
|
||||||
|
|
||||||
|
# This step should succeed, because the check that would fail is disabled
|
||||||
|
- name: Run SQLite schema lint action with invalid schema
|
||||||
|
id: invalid_schema_test
|
||||||
|
uses: ./
|
||||||
|
with:
|
||||||
|
schema-file: 'test_schemas/failure-no-strict.sql'
|
||||||
|
require_strict: false
|
||||||
|
24
action.yml
24
action.yml
@ -1,10 +1,34 @@
|
|||||||
# action.yml
|
# action.yml
|
||||||
name: SQLite schema lint
|
name: SQLite schema lint
|
||||||
description: Enforce constraints on SQLite schemas
|
description: Enforce constraints on SQLite schemas
|
||||||
|
|
||||||
inputs:
|
inputs:
|
||||||
schema-file:
|
schema-file:
|
||||||
description: SQL schema file to lint
|
description: SQL schema file to lint
|
||||||
required: true
|
required: true
|
||||||
|
|
||||||
|
# List of checks
|
||||||
|
require_not_null:
|
||||||
|
description: Enforce that all columns should be marked as `not null` unless they are foreign keys.
|
||||||
|
required: false
|
||||||
|
default: true
|
||||||
|
require_strict:
|
||||||
|
description: Enforce that all tables should be marked as `strict`.
|
||||||
|
required: false
|
||||||
|
default: true
|
||||||
|
forbid_int_type:
|
||||||
|
description: Enforce that all columns should use `integer` type instead of `int`.
|
||||||
|
required: false
|
||||||
|
default: true
|
||||||
|
require_explicit_primary_key:
|
||||||
|
description: Enforce that all tables must have a primary key.
|
||||||
|
required: false
|
||||||
|
default: true
|
||||||
|
require_indexes_for_foreign_keys:
|
||||||
|
description: Enforce that columns referenced by foreign keys must have indexes.
|
||||||
|
required: false
|
||||||
|
default: true
|
||||||
|
|
||||||
runs:
|
runs:
|
||||||
using: 'docker'
|
using: 'docker'
|
||||||
image: 'Dockerfile'
|
image: 'Dockerfile'
|
||||||
|
26
cmd/main.go
26
cmd/main.go
@ -3,6 +3,7 @@ package main
|
|||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
"os"
|
"os"
|
||||||
|
"strings"
|
||||||
|
|
||||||
_ "github.com/mattn/go-sqlite3"
|
_ "github.com/mattn/go-sqlite3"
|
||||||
|
|
||||||
@ -18,7 +19,7 @@ const (
|
|||||||
func main() {
|
func main() {
|
||||||
// Check if a filepath argument is provided
|
// Check if a filepath argument is provided
|
||||||
if len(os.Args) < 2 {
|
if len(os.Args) < 2 {
|
||||||
fmt.Println("Please provide a filepath as the first argument.")
|
fmt.Println(RED + "Please provide a filepath as the first argument." + RESET)
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -37,6 +38,10 @@ func main() {
|
|||||||
is_failure := false
|
is_failure := false
|
||||||
// Execute each check against the database
|
// Execute each check against the database
|
||||||
for _, check := range checks.Checks {
|
for _, check := range checks.Checks {
|
||||||
|
// Checks can be disabled via Github config / environment variables
|
||||||
|
if !is_check_enabled(check) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
results, err := check.Execute(db)
|
results, err := check.Execute(db)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
panic(err)
|
panic(err)
|
||||||
@ -58,3 +63,22 @@ func main() {
|
|||||||
}
|
}
|
||||||
fmt.Println(GREEN + "Success" + RESET)
|
fmt.Println(GREEN + "Success" + RESET)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// github_actions_input_env_var converts an input name to the corresponding
|
||||||
|
// environment variable name used by GitHub Actions.
|
||||||
|
func github_actions_input_env_var(name string) string {
|
||||||
|
// GitHub normalizes both hyphens and underscores to underscores, then uppercases the name
|
||||||
|
normalized := strings.NewReplacer("-", "_", " ", "_").Replace(name)
|
||||||
|
return "INPUT_" + strings.ToUpper(normalized)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Setting the environment variable INPUT_REQUIRE_NOT_NULL="false" disables the "require_not_null" check
|
||||||
|
func is_check_enabled(c checks.Check) bool {
|
||||||
|
val, is_set := os.LookupEnv(github_actions_input_env_var(c.Name))
|
||||||
|
if !is_set {
|
||||||
|
// Enable all checks by default
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
// Anything except "false" is true
|
||||||
|
return val != "false"
|
||||||
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user