boolnames: make default whitelist include 'ok'
This commit is contained in:
56
pkg/boolnames/testdata/src/cases/boolnames.go
vendored
Normal file
56
pkg/boolnames/testdata/src/cases/boolnames.go
vendored
Normal file
@@ -0,0 +1,56 @@
|
||||
package cases
|
||||
|
||||
var isPackageReady bool
|
||||
var packageReady bool // want `boolean name "packageReady" must`
|
||||
|
||||
const hasPackageValue = true
|
||||
const packageValue = true // want `boolean name "packageValue" must`
|
||||
|
||||
type FeatureFlag bool
|
||||
|
||||
type Predicate func() bool
|
||||
|
||||
var canEvaluate Predicate
|
||||
var evaluate Predicate // want `boolean name "evaluate" must`
|
||||
|
||||
type Config struct {
|
||||
HasOwner bool
|
||||
owner bool // want `boolean name "owner" must`
|
||||
|
||||
CanRun func() bool
|
||||
run func() bool // want `boolean name "run" must`
|
||||
}
|
||||
|
||||
func IsReady() bool { return true }
|
||||
|
||||
func ready() bool { return true } // want `boolean name "ready" must`
|
||||
|
||||
func Find() (int, bool) { return 0, true }
|
||||
func FindPair() (bool, bool) { return true, false }
|
||||
|
||||
func consume(active bool, hasActive bool, predicate func() bool, canCheck func() bool) (ok bool) { // want `boolean name "consume" must` `boolean name "active" must` `boolean name "predicate" must`
|
||||
ready := true // want `boolean name "ready" must`
|
||||
isReady := true
|
||||
|
||||
var enabled bool // want `boolean name "enabled" must`
|
||||
var wasEnabled bool
|
||||
|
||||
var namedFlag FeatureFlag // want `boolean name "namedFlag" must`
|
||||
var isNamedFlag FeatureFlag
|
||||
|
||||
checker := func() bool { return true } // want `boolean name "checker" must`
|
||||
hasChecker := func() bool { return true }
|
||||
|
||||
_ = func(active bool) (ok bool) { // want `boolean name "active" must`
|
||||
return ok
|
||||
}
|
||||
|
||||
return ready || isReady || enabled || wasEnabled || bool(namedFlag) || bool(isNamedFlag) || checker() || hasChecker() || active || hasActive || predicate() || canCheck()
|
||||
}
|
||||
|
||||
func (flag FeatureFlag) String() string { // want `boolean name "flag" must`
|
||||
if flag {
|
||||
return "true"
|
||||
}
|
||||
return "false"
|
||||
}
|
||||
12
pkg/boolnames/testdata/src/casescustom/boolnames.go
vendored
Normal file
12
pkg/boolnames/testdata/src/casescustom/boolnames.go
vendored
Normal file
@@ -0,0 +1,12 @@
|
||||
package casescustom
|
||||
|
||||
var ok bool
|
||||
var truthyValue bool
|
||||
|
||||
var ready bool // want `boolean name "ready" must start with truthy`
|
||||
var isReady bool // want `boolean name "isReady" must start with truthy`
|
||||
var hasOwner bool // want `boolean name "hasOwner" must start with truthy`
|
||||
var truthy bool // want `boolean name "truthy" must start with truthy`
|
||||
|
||||
func truthyCheck() bool { return true }
|
||||
func canCheck() bool { return true } // want `boolean name "canCheck" must start with truthy`
|
||||
Reference in New Issue
Block a user