Enable no-dot-import lint check
All checks were successful
CI / release-test (push) Successful in 1m36s

This commit is contained in:
wispem-wantex 2025-11-08 19:59:59 -08:00
parent dbde3c8724
commit 912210cc90
2 changed files with 3 additions and 2 deletions

View File

@ -58,9 +58,10 @@ linters:
checks: checks:
- all - all
- -ST1000 # Re-enable this once we have docstrings - -ST1000 # Re-enable this once we have docstrings
- -ST1001 # Dot imports are good sometimes (e.g., in test packages)
- -ST1003 # I like snake_case - -ST1003 # I like snake_case
- -ST1013 # HTTP status codes are shorter and more readable than names - -ST1013 # HTTP status codes are shorter and more readable than names
dot-import-whitelist:
- "git.offline-twitter.com/offline-labs/gas-stack/pkg/flowutils"
exclusions: exclusions:
generated: lax # Don't lint generated files generated: lax # Don't lint generated files
paths: paths:

View File

@ -1,8 +1,8 @@
TODO: auto-timestamps TODO: auto-timestamps
- SaveXyz should set created_at and updated_at; shouldn't touch is_deleted or deleted_at - SaveXyz should set created_at and updated_at; shouldn't touch is_deleted or deleted_at
- if soft delete is enabled, DeleteXyz should do update (not delete) and set is_deleted and deleted_at - if soft delete is enabled, DeleteXyz should do update (not delete) and set is_deleted and deleted_at
- ...and DeleteXyz should have pointer receiver for soft-delete
- SaveXyz shouldn't set created_at in the do-update branch - SaveXyz shouldn't set created_at in the do-update branch
- DeleteXyz should have pointer receiver
- GetXyzByID should include `ErrItemIsDeleted` if item is soft-deleted - GetXyzByID should include `ErrItemIsDeleted` if item is soft-deleted
TODO: primary-key TODO: primary-key