When doing reply-joining of tombstones, ignore cursors and labels
This commit is contained in:
parent
3dc9889725
commit
eae3ebe3e7
@ -587,17 +587,17 @@ func (api_response APIV2Response) ToTweetTrove() (TweetTrove, error) {
|
||||
continue
|
||||
}
|
||||
// Infer "in_reply_to_id" for tombstoned tweets from the order of entries, if applicable
|
||||
if entry.Content.EntryType != "TimelineTimelineItem" {
|
||||
// Only check back up the parent thread, which will all be "TimelineTimelineItems".
|
||||
// i.e., skip replies
|
||||
// TODO: maybe don't skip replies?
|
||||
if entry.Content.EntryType == "TimelineTimelineItem" {
|
||||
entry_type, main_tweet_id := entry.ParseID()
|
||||
if entry_type == "cursor-showmorethreadsprompt" || entry_type == "cursor-bottom" || entry_type == "cursor-showmorethreads" {
|
||||
// Skip cursors
|
||||
// - "cursor-bottom" => auto-loads more replies when you scroll it into view
|
||||
// - "cursor-showmorethreadsprompt" => "Show additional replies, including those that may contain offensive content" button
|
||||
// - "cursor-showmorethreads" => "Show more replies" button
|
||||
continue
|
||||
}
|
||||
entry_type, main_tweet_id := entry.ParseID()
|
||||
if entry_type == "cursor-showmorethreadsprompt" || entry_type == "cursor-bottom" {
|
||||
// Skip cursors
|
||||
// - "cursor-bottom" => load more high-quality replies
|
||||
// - "cursor-showmorethreadsprompt" => "Show additional replies, including those that may contain offensive content"
|
||||
if entry_type == "label" {
|
||||
// Skip labels / headers
|
||||
continue
|
||||
}
|
||||
if entry_type != "tweet" {
|
||||
@ -616,6 +616,9 @@ func (api_response APIV2Response) ToTweetTrove() (TweetTrove, error) {
|
||||
_, prev_entry_id := api_response.GetMainInstruction().Entries[i-1].ParseID()
|
||||
main_tweet.InReplyToID = prev_entry_id
|
||||
ret.Tweets[main_tweet_id] = main_tweet
|
||||
} else if entry.Content.EntryType == "TimelineTimelineModule" {
|
||||
// TODO: check reply threads for tombstones as well
|
||||
}
|
||||
}
|
||||
|
||||
// Add in any tombstoned user handles and IDs if possible, by reading from the replies
|
||||
|
Loading…
x
Reference in New Issue
Block a user