me/offline-twitter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lint error, add test for empty polling result

Browse Source
This commit is contained in:
Alessio 2023-12-24 19:43:00 -06:00
parent bd90b1c528
commit db692e747a
3 changed files with 45 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/webserver/handler_messages.go
View File

@ -4,8 +4,8 @@ import (
"encoding/json"
"io"
"net/http"
"strings"
"strconv"
"strings"
"gitlab.com/offline-twitter/twitter_offline_engine/pkg/persistence"
"gitlab.com/offline-twitter/twitter_offline_engine/pkg/scraper"
@ -74,7 +74,7 @@ func (app *Application) Messages(w http.ResponseWriter, r *http.Request) {
chat_view_data.MergeWith(chat_contents.DMTrove)
chat_view_data.MessageIDs = chat_contents.MessageIDs
if len(chat_view_data.MessageIDs) > 0 {
last_message_id := chat_view_data.MessageIDs[len(chat_view_data.MessageIDs) - 1]
last_message_id := chat_view_data.MessageIDs[len(chat_view_data.MessageIDs)-1]
chat_view_data.LatestPollingTimestamp = int(chat_view_data.Messages[last_message_id].SentAt.Unix())
}

44
internal/webserver/server_test.go
View File

@ -612,10 +612,13 @@ func TestMessagesRoom(t *testing.T) {
// Should have the poller at the bottom
node := cascadia.Query(root, selector("#new-messages-poller"))
assert.NotNil(node)
assert.Contains(node.Attr, html.Attribute{Key: "hx-get", Val: "/messages/1488963321701171204-1178839081222115328?poll&latest_timestamp=1686025129144"})
assert.Contains(node.Attr, html.Attribute{
Key: "hx-get",
Val: "/messages/1488963321701171204-1178839081222115328?poll&latest_timestamp=1686025129144",
})
}
// Loading the page since
// Loading the page since a given message
func TestMessagesRoomPollForUpdates(t *testing.T) {
assert := assert.New(t)
require := require.New(t)
@ -634,4 +637,41 @@ func TestMessagesRoomPollForUpdates(t *testing.T) {
root, err := html.Parse(resp.Body)
require.NoError(err)
assert.Len(cascadia.QueryAll(root, selector(".dm-message-and-reacts-container")), 3)
// Should have the poller at the bottom
node := cascadia.Query(root, selector("#new-messages-poller"))
assert.NotNil(node)
assert.Contains(node.Attr, html.Attribute{
Key: "hx-get",
Val: "/messages/1488963321701171204-1178839081222115328?poll&latest_timestamp=1686025129144",
})
}
// Loading the page since latest message (no updates)
func TestMessagesRoomPollForUpdatesEmptyResult(t *testing.T) {
assert := assert.New(t)
require := require.New(t)
// Boilerplate for setting an active user
app := webserver.NewApp(profile)
app.IsScrapingDisabled = true
app.ActiveUser = scraper.User{ID: 1488963321701171204, Handle: "Offline_Twatter"} // Simulate a login
// Chat detail
recorder := httptest.NewRecorder()
req := httptest.NewRequest("GET", "/messages/1488963321701171204-1178839081222115328?poll&latest_timestamp=1686025129144", nil)
req.Header.Set("HX-Request", "true")
app.ServeHTTP(recorder, req)
resp := recorder.Result()
root, err := html.Parse(resp.Body)
require.NoError(err)
assert.Len(cascadia.QueryAll(root, selector(".dm-message-and-reacts-container")), 0)
// Should have the poller at the bottom, with the same value as previously
node := cascadia.Query(root, selector("#new-messages-poller"))
assert.NotNil(node)
assert.Contains(node.Attr, html.Attribute{
Key: "hx-get",
Val: "/messages/1488963321701171204-1178839081222115328?poll&latest_timestamp=1686025129144",
})
}