me/offline-twitter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crashing on non-timeline-module composer button entries

Browse Source
This commit is contained in:
Alessio 2024-10-26 22:11:23 -07:00
parent e319dc1988
commit 90f453c207
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/scraper/api_types_v2.go
View File

@ -492,7 +492,7 @@ func (e APIV2Entry) ToTweetTrove() TweetTrove {
continue continue
} }
if item.Item.ItemContent.ItemType == "TimelineTweetComposer" { if item.Item.ItemContent.ItemType == "TimelineTweetComposer" {
// Composer button // Composer button (timeline module version)
continue continue
} }
trove, err := item.Item.ItemContent.TweetResults.ToTweetTrove() trove, err := item.Item.ItemContent.TweetResults.ToTweetTrove()
@ -518,6 +518,10 @@ func (e APIV2Entry) ToTweetTrove() TweetTrove {
// TODO: user feed tombstone entries // TODO: user feed tombstone entries
return NewTweetTrove() return NewTweetTrove()
} }
if e.Content.ItemContent.ItemType == "TimelineTweetComposer" {
// Composer button (regular thread version)
return NewTweetTrove()
}
if strings.Split(e.EntryID, "-")[0] == "messageprompt" { if strings.Split(e.EntryID, "-")[0] == "messageprompt" {
return NewTweetTrove() return NewTweetTrove()
} }

14
pkg/scraper/api_types_v2_test.go
View File

@ -976,7 +976,7 @@ func TestTweetWithImplicitQuotedTombstone(t *testing.T) {
assert.Equal(t2.TombstoneType, "unavailable") assert.Equal(t2.TombstoneType, "unavailable")
} }
func TestNoFailOnComposerEntry(t *testing.T) { func TestNoFailOnComposerEntryInTimelineModule(t *testing.T) {
assert := assert.New(t) assert := assert.New(t)
require := require.New(t) require := require.New(t)
data, err := os.ReadFile("test_responses/api_v2/composer_entry_item.json") data, err := os.ReadFile("test_responses/api_v2/composer_entry_item.json")
@ -988,3 +988,15 @@ func TestNoFailOnComposerEntry(t *testing.T) {
trove := entry_result.ToTweetTrove() trove := entry_result.ToTweetTrove()
assert.Len(trove.Tweets, 0) assert.Len(trove.Tweets, 0)
} }
func TestNoFailOnComposerEntryInRegularThread(t *testing.T) {
assert := assert.New(t)
require := require.New(t)
data, err := os.ReadFile("test_responses/api_v2/composer_entry_item_non_module.json")
require.NoError(err)
var entry_result APIV2Entry
err = json.Unmarshal(data, &entry_result)
require.NoError(err)
trove := entry_result.ToTweetTrove()
assert.Len(trove.Tweets, 0)
}

1
pkg/scraper/test_responses/api_v2/composer_entry_item_non_module.json Normal file
View File

@ -0,0 +1 @@
{"entryId":"tweetcomposer--1","sortIndex":"7407168758699622302","content":{"entryType":"TimelineTimelineItem","__typename":"TimelineTimelineItem","itemContent":{"itemType":"TimelineTweetComposer","__typename":"TimelineTweetComposer","composerDisplayType":"SelfThread","composerButtonText":"Add another post","composerButtonUrl":{"url":"twitter://post?in_reply_to_status_id=1816203278155153495","urlType":"DeepLink"}}}}