From 857b9c52552955d9ecb568964a4a1a7d10afcd34 Mon Sep 17 00:00:00 2001 From: Alessio Date: Sat, 26 Feb 2022 16:06:51 -0800 Subject: [PATCH] Fix linting error --- persistence/user_queries.go | 9 +++++---- persistence/user_queries_test.go | 6 ++++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/persistence/user_queries.go b/persistence/user_queries.go index 37c8562..e81b372 100644 --- a/persistence/user_queries.go +++ b/persistence/user_queries.go @@ -196,14 +196,15 @@ func (p Profile) CheckUserContentDownloadNeeded(user scraper.User) bool { */ func (p Profile) SetUserFollowed(user *scraper.User, is_followed bool) { result, err := p.DB.Exec("update users set is_followed = ? where id = ?", is_followed, user.ID) + if err != nil { + panic(fmt.Sprintf("Error inserting user with handle %q: %s", user.Handle, err.Error())) + } + count, err := result.RowsAffected() if err != nil { panic("Unknown error: " + err.Error()) } - if count, _ := result.RowsAffected(); count != 1 { + if count != 1 { panic(fmt.Sprintf("User with handle %q not found", user.Handle)) } - if err != nil { - panic(fmt.Sprintf("Error inserting user with handle %q: %s", user.Handle, err.Error())) - } user.IsFollowed = is_followed } diff --git a/persistence/user_queries_test.go b/persistence/user_queries_test.go index 0df88ce..29baa31 100644 --- a/persistence/user_queries_test.go +++ b/persistence/user_queries_test.go @@ -225,7 +225,8 @@ func TestFollowUnfollowUser(t *testing.T) { user := create_dummy_user() assert.False(user.IsFollowed) - profile.SaveUser(user) + err := profile.SaveUser(user) + assert.NoError(err) profile.SetUserFollowed(&user, true) assert.True(user.IsFollowed) @@ -236,7 +237,8 @@ func TestFollowUnfollowUser(t *testing.T) { assert.Equal(user.ID, user_reloaded.ID) // Verify it's the same user assert.True(user_reloaded.IsFollowed) - profile.SaveUser(user) // should NOT un-set is_followed + err = profile.SaveUser(user) // should NOT un-set is_followed + assert.NoError(err) user_reloaded, err = profile.GetUserByHandle(user.Handle) require.NoError(t, err) assert.Equal(user.ID, user_reloaded.ID) // Verify it's the same user