From 7f24bb7893eb2b4cebc1f23c99d586c17371d2b7 Mon Sep 17 00:00:00 2001
From: Alessio <me@playfulpachyderm.com>
Date: Sat, 19 Aug 2023 16:12:46 -0300
Subject: [PATCH] Add a lint check to close SQL resources (stmts and rows)

---
 .golangci.yaml                      | 1 +
 pkg/persistence/compound_queries.go | 2 ++
 pkg/persistence/space_queries.go    | 1 +
 pkg/persistence/user_queries.go     | 1 +
 4 files changed, 5 insertions(+)

diff --git a/.golangci.yaml b/.golangci.yaml
index 50cd0fb..030ae91 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -30,6 +30,7 @@ linters:
     - gofmt
     - errorlint
     - nolintlint
+    - sqlclosecheck
 
 
   # Useless linters:
diff --git a/pkg/persistence/compound_queries.go b/pkg/persistence/compound_queries.go
index 9c4a5b2..db70680 100644
--- a/pkg/persistence/compound_queries.go
+++ b/pkg/persistence/compound_queries.go
@@ -226,6 +226,7 @@ func (p Profile) GetTweetDetail(id TweetID) (TweetDetailView, error) {
 	if err != nil {
 		panic(err)
 	}
+	defer stmt.Close()
 
 	// Main tweet and parents
 	var thread []Tweet
@@ -257,6 +258,7 @@ func (p Profile) GetTweetDetail(id TweetID) (TweetDetailView, error) {
 	if err != nil {
 		panic(err)
 	}
+	defer stmt.Close()
 	err = stmt.Select(&replies, id)
 	if err != nil {
 		panic(err)
diff --git a/pkg/persistence/space_queries.go b/pkg/persistence/space_queries.go
index e249e27..c7d597b 100644
--- a/pkg/persistence/space_queries.go
+++ b/pkg/persistence/space_queries.go
@@ -66,6 +66,7 @@ func (p Profile) GetSpaceById(id scraper.SpaceID) (space scraper.Space, err erro
 	if errors.Is(err, sql.ErrNoRows) {
 		err = nil
 	}
+	defer rows.Close()
 	if err != nil {
 		panic(err)
 	}
diff --git a/pkg/persistence/user_queries.go b/pkg/persistence/user_queries.go
index 10e5536..4eceec6 100644
--- a/pkg/persistence/user_queries.go
+++ b/pkg/persistence/user_queries.go
@@ -213,6 +213,7 @@ func (p Profile) GetAllFollowedUsers() []scraper.UserHandle {
 	if err != nil {
 		panic(err)
 	}
+	defer rows.Close()
 
 	ret := []scraper.UserHandle{}