me/offline-twitter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make 'tweet not in database' a named error that can be checked for

Browse Source
This commit is contained in:
Alessio 2023-08-09 15:32:50 -03:00
parent dcdec91d62
commit 7d2f35be68
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/persistence/tweet_queries.go
View File

@ -132,7 +132,11 @@ func (p Profile) GetTweetById(id TweetID) (Tweet, error) {
`, id)
if err != nil {
return Tweet{}, fmt.Errorf("Error executing GetTweetByID(%d):\n %w", id, err)
if err == sql.ErrNoRows {
return Tweet{}, fmt.Errorf("GetTweetById %d: %w", id, ErrNotInDB)
} else {
panic(err)
}
}
t.Spaces = []Space{}

10
pkg/persistence/tweet_queries_test.go
View File

@ -8,6 +8,7 @@ import (
"github.com/go-test/deep"
"gitlab.com/offline-twitter/twitter_offline_engine/pkg/persistence"
"gitlab.com/offline-twitter/twitter_offline_engine/pkg/scraper"
)
@ -326,3 +327,12 @@ func TestCheckTweetContentDownloadNeeded(t *testing.T) {
// Should no longer need a download
assert.False(profile.CheckTweetContentDownloadNeeded(tweet))
}
func TestLoadMissingTweet(t *testing.T) {
profile_path := "test_profiles/TestTweetQueries"
profile := create_or_load_profile(profile_path)
_, err := profile.GetTweetById(scraper.TweetID(6234234)) // Random number
require.Error(t, err)
assert.ErrorIs(t, err, persistence.ErrNotInDB)
}