me/offline-twitter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't double-download tweet contents

Browse Source
This commit is contained in:
Alessio 2021-12-21 21:57:00 -05:00
parent 5d44186f91
commit 692d3de564
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/twitter/main.go
View File

@ -174,7 +174,7 @@ func fetch_tweet_conversation(tweet_identifier string) {
if err != nil { if err != nil {
die(fmt.Sprintf("Error saving tweet (id %d): %s", t.ID, err.Error()), false, 4) die(fmt.Sprintf("Error saving tweet (id %d): %s", t.ID, err.Error()), false, 4)
} }
err = profile.DownloadTweetContentFor(&t) _, err = profile.DownloadTweetContentIfNeeded(&t)
if err != nil { if err != nil {
die("Error getting tweet content: " + err.Error(), false, 11) die("Error getting tweet content: " + err.Error(), false, 11)
} }
@ -217,7 +217,7 @@ func fetch_user_feed(handle string, how_many int) {
if err != nil { if err != nil {
die("Error saving tweet: " + err.Error(), false, 4) die("Error saving tweet: " + err.Error(), false, 4)
} }
err = profile.DownloadTweetContentFor(&t) _, err = profile.DownloadTweetContentIfNeeded(&t)
if err != nil { if err != nil {
die("Error getting tweet content: " + err.Error(), false, 11) die("Error getting tweet content: " + err.Error(), false, 11)
} }
@ -286,7 +286,7 @@ func search(query string) {
if err != nil { if err != nil {
die("Error saving tweet: " + err.Error(), false, 4) die("Error saving tweet: " + err.Error(), false, 4)
} }
err = profile.DownloadTweetContentFor(&t) _, err = profile.DownloadTweetContentIfNeeded(&t)
if err != nil { if err != nil {
die("Error getting tweet content: " + err.Error(), false, 11) die("Error getting tweet content: " + err.Error(), false, 11)
} }

14
persistence/media_download.go
View File

@ -174,5 +174,17 @@ func (p Profile) DownloadUserContentIfNeeded(u *scraper.User) (bool, error) {
return false, nil return false, nil
} }
return true, p.DownloadUserContentFor(u) return true, p.DownloadUserContentFor(u)
}
/**
* Download a Tweet's content, if needed.
*
* Returns whether anything was downloaded or not.
*/
func (p Profile) DownloadTweetContentIfNeeded(t *scraper.Tweet) (bool, error) {
if !p.CheckTweetContentDownloadNeeded(*t) {
return false, nil
}
return true, p.DownloadTweetContentFor(t)
} }