me/offline-twitter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handle 'X Premium' native ads in notifications

Browse Source
This commit is contained in:
Alessio 2024-12-09 14:56:17 -08:00
parent 1b290d9b5c
commit 5b7713bb05
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/scraper/api_types_notifications.go
View File

@ -171,6 +171,10 @@ func (t *TweetResponse) ToTweetTroveAsNotifications(current_user_id UserID) (Twe
// TODO: communities // TODO: communities
delete(ret.Notifications, notification.ID) delete(ret.Notifications, notification.ID)
continue continue
} else if strings.Contains(entry.Content.Item.ClientEventInfo.Element, "promotion_premium") {
// Native ad for buying X Premium; ignore
delete(ret.Notifications, notification.ID)
continue
} }
} }

4
pkg/scraper/api_types_notifications_test.go
View File

@ -138,6 +138,10 @@ func TestParseNotificationsPage(t *testing.T) {
// assert.True(is_ok) // assert.True(is_ok)
// assert.Equal(NOTIFICATION_TYPE_COMMUNITY_PINNED_POST, notif12.Type) // assert.Equal(NOTIFICATION_TYPE_COMMUNITY_PINNED_POST, notif12.Type)
// Ad for X Premium
_, is_ok = tweet_trove.Notifications["FKncQJGVgAQAAAABSQ3bEak9zbD6K-zcrss"]
assert.False(is_ok)
// Check users // Check users
for _, u_id := range []UserID{1458284524761075714, 28815778, 1633158398555353096} { for _, u_id := range []UserID{1458284524761075714, 28815778, 1633158398555353096} {
_, is_ok := tweet_trove.Users[u_id] _, is_ok := tweet_trove.Users[u_id]

2
pkg/scraper/test_responses/notifications/notifications_response_first_page.json
View File

File diff suppressed because one or more lines are too long