From 5899732fa58b405310a726f9c6f6fac459c72c80 Mon Sep 17 00:00:00 2001 From: Alessio Date: Wed, 21 Jun 2023 12:25:42 -0300 Subject: [PATCH] Do tombstoned user fetching for apiv2 --- scraper/api_types_v2.go | 2 +- scraper/api_types_v2_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/scraper/api_types_v2.go b/scraper/api_types_v2.go index 94d8e58..2ec19e7 100644 --- a/scraper/api_types_v2.go +++ b/scraper/api_types_v2.go @@ -662,7 +662,7 @@ func (api_response APIV2Response) ToTweetTrove() (TweetTrove, error) { existing_user.Handle = tweet.in_reply_to_user_handle } ret.Users[replied_tweet.UserID] = existing_user - // TODO: add to ret.TombstonedUsers? + ret.TombstoneUsers = append(ret.TombstoneUsers, existing_user.Handle) ret.Tweets[replied_tweet.ID] = replied_tweet } diff --git a/scraper/api_types_v2_test.go b/scraper/api_types_v2_test.go index 24ef8ee..01ff63a 100644 --- a/scraper/api_types_v2_test.go +++ b/scraper/api_types_v2_test.go @@ -650,6 +650,7 @@ func TestAPIV2ConversationThreadWithTombstones(t *testing.T) { assert.True(is_ok) assert.False(t3_user.IsIdFake) assert.Equal(UserHandle("itsbackwereover"), t3_user.Handle) + assert.Contains(trove.TombstoneUsers, UserHandle("itsbackwereover")) t4, is_ok := trove.Tweets[1454526270809726977] assert.True(is_ok)