me/offline-twitter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update tiny profile image logic for users with no profile image (including banned users)

Browse Source
This commit is contained in:
Alessio 2022-01-06 15:21:27 -05:00
parent 1a9ba75355
commit 1ea97e669a
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
scraper/user.go
View File

@ -10,6 +10,8 @@ import (
"offline_twitter/terminal_utils" "offline_twitter/terminal_utils"
) )
const DEFAULT_PROFILE_IMAGE_URL = "https://abs.twimg.com/sticky/default_profile_images/default_profile.png"
type UserID int64 type UserID int64
type UserHandle string type UserHandle string
@ -173,14 +175,27 @@ func (u User) compute_banner_image_local_path() string {
* Get the URL where we would expect to find a User's tiny profile image * Get the URL where we would expect to find a User's tiny profile image
*/ */
func (u User) GetTinyProfileImageUrl() string { func (u User) GetTinyProfileImageUrl() string {
// Check that the format is as expected
r := regexp.MustCompile(`(\.\w{2,4})$`) r := regexp.MustCompile(`(\.\w{2,4})$`)
// If profile image is empty, then just use the default profile image
if u.ProfileImageUrl == "" {
return r.ReplaceAllString(DEFAULT_PROFILE_IMAGE_URL, "_normal$1")
}
// Check that the format is as expected
if !r.MatchString(u.ProfileImageUrl) { if !r.MatchString(u.ProfileImageUrl) {
panic(fmt.Sprintf("Weird profile image url: %s", u.ProfileImageUrl)) panic(fmt.Sprintf("Weird profile image url: %s", u.ProfileImageUrl))
} }
return r.ReplaceAllString(u.ProfileImageUrl, "_normal$1") return r.ReplaceAllString(u.ProfileImageUrl, "_normal$1")
} }
/**
* If user has a profile image, return the local path for its tiny version.
* If user has a blank or default profile image, return a non-personalized default path.
*/
func (u User) GetTinyProfileImageLocalPath() string { func (u User) GetTinyProfileImageLocalPath() string {
if u.ProfileImageUrl == "" {
return path.Base(u.GetTinyProfileImageUrl())
}
return string(u.Handle) + "_profile_" + path.Base(u.GetTinyProfileImageUrl()) return string(u.Handle) + "_profile_" + path.Base(u.GetTinyProfileImageUrl())
} }

8
scraper/user_test.go
View File

@ -115,6 +115,14 @@ func TestParseBannedUser(t *testing.T) {
if user.IsBanned != true { if user.IsBanned != true {
t.Errorf("Expected user to be banned") t.Errorf("Expected user to be banned")
} }
// Test generation of profile images for banned user
if user.GetTinyProfileImageUrl() != "https://abs.twimg.com/sticky/default_profile_images/default_profile_normal.png" {
t.Errorf("Incorrect tiny profile image URL for banned user: %q", user.GetTinyProfileImageUrl())
}
if user.GetTinyProfileImageLocalPath() != "default_profile_normal.png" {
t.Errorf("Incorrect tiny profile image local path for banned user: %q", user.GetTinyProfileImageLocalPath())
}
} }
/** /**